Open
Conversation
alexr00
requested changes
Sep 25, 2025
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
This was a really cool demo last week! I haven't finished reviewing yet, but I have a lot of comments so I'm posting them now.
Comment on lines
258
to
262
| // Open the first changed file using the existing openDiff pattern | ||
| // if (changedFiles.length > 0) { | ||
| // const firstFile = changedFiles[0]; | ||
| // await this.openFileInDiffView(folderManager, firstFile, branchName, baseBranch); | ||
| // } |
| return `task/${truncated}`; | ||
| } | ||
|
|
||
| private async ensureUniqueBranchName(baseName: string): Promise<string> { |
Member
There was a problem hiding this comment.
Maybe useful?
vscode-pull-request-github/src/github/pullRequestGitHelper.ts
Lines 352 to 353 in e5ce106
| } | ||
| } | ||
|
|
||
| private folderManagerMatchesRepo(folderManager: FolderRepositoryManager, owner: string, repo: string): boolean { |
Member
There was a problem hiding this comment.
Duplicate code
vscode-pull-request-github/src/github/taskDashboardWebviewProvider.ts
Lines 430 to 431 in e5ce106
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an experimental dashboard for viewing issues and creating sessions (either local or Padawan) to work on them
The feature is gated behind an experimental setting. There are still a lot of known bugs / limitations but we'd like to self host on this when we can